astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

Change font colour of unread #337

Open hughwilliams94 opened 7 years ago

hughwilliams94 commented 7 years ago

I am having trouble distinguishing between read and unread using the emboldened font in a dark GTK theme. I woud like to change the font colour of unread emails if possible. I tried poking around the in thread-view.scss but couldn't decipher which value to change.

gauteh commented 7 years ago

Hugh Williams writes on mai 5, 2017 11:01:

I am having trouble distinguishing between read and unread using the emboldened font in a dark GTK theme. I woud like to change the font colour of unread emails if possible. I tried poing around the in thread-view.scss but couldn't decipher which value to change.

So I assume this is for thread-view and not thread-index. You should be able to use the nm-unread CSS tag. Have a look here for how to use a custom theme: https://github.com/astroidmail/astroid/wiki/Customizing-the-user-interface .

See #268 for some info on the nm-unread CSS tag. @mxmehl and @hugoroy might have some examples.

hughwilliams94 commented 7 years ago

I mean in the thread-index sorry got a little confused with terminology.

gauteh commented 7 years ago

Hugh Williams writes on mai 5, 2017 11:17:

I mean in the thread-index sorry got a little confused with terminology.

Then you have to look in the config, that's where the theming of the thread-index takes place. You will also be able to customize the appearance of the tags by modifying a plugin: https://github.com/astroidmail/astroid-plugin-hls-hsv-tagcolor. I don't think it's possible to configure all the elements in the thread-index yet.

hughwilliams94 commented 7 years ago

Unfortunately I see no option in the config file to adjust the font of the from name in the thread index, the issue perhaps lies with my GTK theme thanks for your help.

gauteh commented 7 years ago

Hugh Williams writes on mai 5, 2017 11:23:

Unfortunately I see no option in the config file to adjust the font of the from name in the thread index, the issue perhaps lies with my GTK theme thanks for your help.

Yes, you are right, it is probably not possible to theme these settings yet. I think it would be best to do this through a plugin since users might want to use other logics for determining appearance.

hugoroy commented 7 years ago

Can you post a screenshot?

hughwilliams94 commented 7 years ago

In this instance the first two messages are unread and the third is read, the difference is too subtle to notice at a glance or in high.

screenshot_20170505_121610

Sorry not to include more but i hae to hide email addresses

gauteh commented 7 years ago

Hugh Williams writes on mai 5, 2017 13:18:

In this instance the first two messages are unread and the third is read, the difference is too subtle to notice at a glance or in high.

screenshot_20170505_121610

Sorry not to include more but i hae to hide email addresses

It might be nice to have some common configuration options available in the config. Perhaps underlining unread messages (configurable)?

hugoroy commented 7 years ago

Is this the default font of your system (which system?) or a custom font of your choice?

How does it look if you try with another font where the bold has more weight?

@gaute underlining does not seem like a good idea to me; I think a different background colour would be more efficient

gauteh commented 7 years ago

Hugo Roy writes on mai 5, 2017 13:23:

@gaute underlining does not seem like a good idea to me; I think a different background colour would be more efficient

Ok, yeah, might get a bit messy.

hughwilliams94 commented 7 years ago

I haven't adjusted any font settings within Astroid. I think it may be my system font (Droid Sans on Arch Linux KDE) but can't be quite sure.

hugoroy commented 7 years ago

@hughwilliams94 This is a monospace font so it cannot be Droid Sans :-)

@gauteh Gmail does bold + background - may be worth trying if it improves the UI overall

capture d ecran de 2017-05-05 13-27-43

gauteh commented 7 years ago

Hugo Roy writes on mai 5, 2017 13:32:

@hughwilliams94 This is a monospace font so it cannot be Droid Sans :-)

@gauteh Gmail does bold + background - may be worth trying if it improves the UI overall

Good point, I've been trying to get GTK theme colors for different types of selections, but with no success yet - otherwise this would mess up the dark background which depends on the user theme.

hughwilliams94 commented 7 years ago

Sorry, I meant Droid Sans Mono. The font in astroid does not seem to change when I adjust my default system monospace font so I am not sure which font it is.

hugoroy commented 7 years ago

↪ Hugh Williams / mai 5, 2017 13:34:

Sorry, I meant Droid Sans Mono. The font in astroid does not seem to change when I adjust my default system monospace font so I am not sure which font it is.

Since this is GTK, maybe try to see with http://live.gnome.org/GnomeTweakTool

But anyway, I just tried the dark theme and it was also difficult for me although I have a high contrast between the normal and the bold versions of the font I use.

So there must be something with the dark theme that makes it particularly difficult.

hughwilliams94 commented 7 years ago

I run KDE so I am not sure if the Gnome Tweak Tool will help, I have adjusted my GTK theme to a lighter version for the moment. Interestingly when I change my GTK theme default font in KDE settings to another monospace font the tab text e.g. inbox etc. changes but the rest of the text remains the same.

gauteh commented 7 years ago

Hugh Williams writes on mai 5, 2017 13:51:

I run KDE so I am not sure if the Gnome Tweak Tool will help, I have adjusted my GTK theme to a lighter version for the moment. Interestingly when I change my GTK theme default font in KDE settings to another monospace font the tab text e.g. inbox etc. changes but the rest of the text remains the same.

The font-description is loaded on start up. You have to restart astroid.

hughwilliams94 commented 7 years ago

I have restarted, the tab titles change to respect the font change but the thread index is unchanged

gauteh commented 7 years ago

Hugh Williams writes on mai 5, 2017 13:53:

I have restarted, the tab titles change to respect the font change but the thread index is unchanged

Also the tabs use regular font while thread-index use system monospace font.

hughwilliams94 commented 7 years ago

Ah OK, I can only set one font for my GTK theme via KDE settings so I am not sure what is going. :)

gauteh commented 7 years ago

Related #219