astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

Tab keybinding does not work when defined for MainWindow #479

Open mturquette opened 6 years ago

mturquette commented 6 years ago

I have the following in my ~/.config/astroid/keybindings:

main_window.next_page=Tab

But instead of cycling through the windows, pressing the tab key just selects the random buttons on the interface as you would expect it to in most programs. You can see what I mean in the two screenshots below. The first image is how things look before pressing tab, the second is after pressing tab:

beforetab

aftertab

I have also tried KP_Tab and ISO_Left_Tab. Binding it to a "normal" unused key such as i yields the desired behavior. Checking the log I see that there is no Error from mapping the Tab key.

OS is Mac OS X High Sierra 10.13.3

Any thoughts?

gauteh commented 6 years ago

Does Tab normally work (before you bind it to something else) like it should to jump to next unread?

gauteh commented 6 years ago

I noticed that Tab cannot be defined for main_window, but can be defined for the sub-modes. Probably because the notebook (pages) catches the event before it gets to the main window.

mturquette commented 6 years ago

Correct, the default binding (jump to next unread) works fine.

On Mar 9, 2018 10:58 PM, "Gaute Hope" notifications@github.com wrote:

Does Tab normally work (before you bind it to something else) like it should to jump to next unread?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/astroidmail/astroid/issues/479#issuecomment-372008545, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAy22paxUqVJ7jWOnXaw1Jh0YFPPBy5ks5tc3mhgaJpZM4SlJ_N .

gauteh commented 6 years ago

Not really, but if it does not bug anyone let’s close it for now. Enough other issues 😉

lør. 10. mar. 2018 kl. 17:33 skrev Michael Turquette < notifications@github.com>:

Ok, so does that close the issue? I've simple bound another key for now

On Mar 9, 2018 11:03 PM, "Gaute Hope" notifications@github.com wrote:

I noticed that Tab cannot be defined for main_window, but can be defined for the sub-modes. Probably because the notebook (pages) catches the event before it gets to the main window.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/astroidmail/astroid/issues/479#issuecomment-372008739>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAy25aWwbhI3rKw2jmykGuzyUhFnS0fks5tc3qygaJpZM4SlJ_N

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/astroidmail/astroid/issues/479#issuecomment-372043015, or mute the thread https://github.com/notifications/unsubscribe-auth/AADd-68rkSrS0pxSwg2pVtz83EMcl8l2ks5tdABugaJpZM4SlJ_N .