search

astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

Ctrl-Space not activating Alternative Part widget in preview view (v0.14) #584

Closed dnebauer closed 2 years ago

dnebauer commented 6 years ago

In version 0.14 Ctrl-Space no longer activates the Alternative part widget when previewing in Edit Mode. The Enter key, which in other modes activates the widget, in Edit Mode opens the message for (re-)editing.

Ctrl-Space worked fine for activating the widget in Edit Mode back in 0.11.1 -- see, for example, this comment and following comments.

gauteh commented 6 years ago

dnebauer writes on October 23, 2018 13:59:

In version 0.14 Ctrl-Space no longer activates the Alternative part widget when previewing in Edit Mode. The Enter key, which in other modes activates the widget, in Edit Mode opens the message for (re-)editing.

For some reason some Ctrl-keybindings do not work in hte ThreadView when in EditMode. If you change it to a simpler key, like just 'o' it starts working again.

dnebauer commented 6 years ago

I can't locate the default keybinding for Ctrl-Space in the output of devel/get_keys.py. What is the target for activating the Alternative part when it has focus?

gauteh commented 6 years ago

https://github.com/astroidmail/astroid/blob/master/src/modes/thread_view/thread_view.cc#L658

On Thu, Oct 25, 2018 at 2:02 PM dnebauer notifications@github.com wrote:

I can't locate the default keybinding for Ctrl-Space in the output of devel/get_keys.py. What is the target for activating the Alternative part when it has focus?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/astroidmail/astroid/issues/584#issuecomment-433023796, or mute the thread https://github.com/notifications/unsubscribe-auth/AADd--a7h4Pjs2nNZcPd2G7Ha-HscFisks5uoahbgaJpZM4X1ZwH .

gauteh commented 6 years ago 
thread_view.activate=Enter
thread_view.activate=o

note that o is already used to open search, so its not a good default choice.