astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

remove minimum width for command bar #668

Closed bjesus closed 5 years ago

bjesus commented 5 years ago

Following on #667, I suggest removing this minimum width setting completely as Astroid already has a default size defined here: https://github.com/astroidmail/astroid/blob/35660d486bed3c856603dcff8e8b52153e8e8da9/src/main_window.cc#L105

As a reference I found this: https://valadoc.org/gtk+-3.0/Gtk.Widget.set_size_request.html

In most cases, set_default_size is a better choice for toplevel windows than this function; setting the default size will still allow users to shrink the window.

Thank you!

gauteh commented 5 years ago

Thanks! Does this cause the entry to be shorter at the same window width? Will it be short even with a wide window?

bjesus commented 5 years ago

You were right, removing the line did make the command bar shrink to its default width which looked too small. I've added entry.set_max_width_chars(600); and now the command bar stretches to fill the available area, like so: Screenshot from 2019-11-02 17-20-45

gauteh commented 5 years ago

Thanks, merged!