search

astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

End test email message bodies with a trailing newline #685

Closed stefanor closed 4 years ago

stefanor commented 4 years ago

Test regressed under gmime 3.2.3, because of the change in jstedfast/gmime@2dd1be81555d787ff1ff03b11e5cb4b9e81630d6

A trailing newline was added to the text/plain message body in the test, causing the round-trip comparison to fail.

Fixes: #676

gauteh commented 4 years ago

Stefano Rivera writes on May 9, 2020 3:54:

Test regressed under gmime 3.2.3, because of the change in jstedfast/gmime@2dd1be81555d787ff1ff03b11e5cb4b9e81630d6

A trailing newline was added to the text/plain message body in the test, causing the round-trip comparison to fail.

Won't this fail on other versions of gmime? Is this part of the newest gmime?

Regards, Gaute

stefanor commented 4 years ago

Won't this fail on other versions of gmime?

Nope. gmime doesn't seem to have been doing any stripping there in the past, it just started to add a trailing newline.

As you can see from the CI tests, it works across at least gmime 3.2.0 (Ubuntu bionic) to 3.2.7 (Debian unstable & Ubuntu devel)

gauteh commented 4 years ago

Ok, thanks, merged