search

astroidmail / astroid

A graphical threads-with-tags style, lightweight and fast, e-mail client for Notmuch
http://astroidmail.github.io
Other
613 stars 65 forks source link

Expanded mail has fixed height regardless of its content #736

Closed l1gi closed 4 months ago

l1gi commented 1 year ago

Hi,

since some Ubuntu apt upgrade all expanded boxes in thread-view has fixed height approx 350px:

expanded

The only way how to see the rest of the content is to drag and move the mouse.

I removed ~/.config/astroid directory, no change.

Collapsed view looks same:

collapsed

Could anyone tell me what could be wrong, please?

Thank you, m.

l1gi commented 1 year ago

And this is on the standard and error output when I hit enter on the message:

(astroid:2604334): gmime-CRITICAL **: 16:31:46.770: internet_address_list_length: assertion 'IS_INTERNET_ADDRESS_LIST (list)' failed

(astroid:2604334): gmime-CRITICAL **: 16:31:46.770: internet_address_list_length: assertion 'IS_INTERNET_ADDRESS_LIST (list)' failed
[16:31:46] [0x00007f29a0ff9640] [M] [error] address: no address in string.

(astroid:2604334): GLib-GObject-CRITICAL **: 16:31:46.770: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
[16:31:47] [0x00007f29c5a40280] [M] [info] re: using installed resource: /usr/share/astroid/ui/thread-view.html
[16:31:47] [0x00007f29c5a40280] [M] [info] re: using installed resource: /usr/share/astroid/ui/thread-view.scss
[16:31:47] [0x00007f29c5a40280] [M] [info] re: using installed resource: /usr/share/astroid/ui/part.scss
[16:31:47] [0x00007f29c5a40280] [M] [info] theme: processing: /usr/share/astroid/ui/thread-view.scss
DEPRECATION WARNING on line 4 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$background-color: null` at the top level.

DEPRECATION WARNING on line 9 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$recv-normal: null` at the top level.

DEPRECATION WARNING on line 12 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$recv-quoted: null` at the top level.

DEPRECATION WARNING on line 15 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$recv-collapsed: null` at the top level.

DEPRECATION WARNING on line 20 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$sent-normal: null` at the top level.

DEPRECATION WARNING on line 24 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$sent-quoted: null` at the top level.

DEPRECATION WARNING on line 28 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$sent-collapsed: null` at the top level.

DEPRECATION WARNING on line 33 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-base-size: null` at the top level.

DEPRECATION WARNING on line 37 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-mono: null` at the top level.

DEPRECATION WARNING on line 41 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-sans: null` at the top level.

DEPRECATION WARNING on line 45 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-family-default: null` at the top level.

DEPRECATION WARNING on line 50 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$email-solid: null` at the top level.

DEPRECATION WARNING on line 54 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$focused-solid: null` at the top level.

DEPRECATION WARNING on line 58 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$sibling-color: null` at the top level.

DEPRECATION WARNING on line 62 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$attachment-color: null` at the top level.

DEPRECATION WARNING on line 66 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$mime-color: null` at the top level.

DEPRECATION WARNING on line 70 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$encrypted: null` at the top level.

DEPRECATION WARNING on line 74 of /usr/share/astroid/ui/thread-view.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$signed: null` at the top level.

[16:31:47] [0x00007f29c5a40280] [M] [info] theme: processing: /usr/share/astroid/ui/part.scss
DEPRECATION WARNING on line 4 of /usr/share/astroid/ui/part.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-base-size: null` at the top level.

DEPRECATION WARNING on line 8 of /usr/share/astroid/ui/part.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-mono: null` at the top level.

DEPRECATION WARNING on line 12 of /usr/share/astroid/ui/part.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-sans: null` at the top level.

DEPRECATION WARNING on line 16 of /usr/share/astroid/ui/part.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$font-family-default: null` at the top level.

[16:31:47] [0x00007f29c5a40280] [M] [info] render: loading html..
[16:31:47] [0x00007f29c5a40280] [M] [info] pc: adding /usr/lib/astroid/web-extensions to web extension search path.
[16:31:47] [0x00007f29c5a40280] [M] [warning] pc: id: 1
[16:31:47] [0x00007f29c5a40280] [M] [info] ky: run, binding: thread_view.run(a) (userdefined: true) to: notmuch tag +archived -- "thread:%1", 
[16:31:47] [0x00007f29c5a40280] [M] [info] ky: run, binding: thread_view.run(A) (userdefined: true) to: notmuch tag -archived -- "thread:%1", 
[16:31:47] [0x00007f29c5a40280] [M] [info] ky: run, binding: thread_view.run(C-m) (userdefined: true) to: notmuch tag +muted -- "thread:%1", 
[16:31:47] [0x00007f29c5a40280] [M] [info] tv: load thread: 0000000000042770
[16:31:47] [0x00007f29c5a40280] [M] [info] db: open db read-only, waiting for lock..
[16:31:47] [0x00007f29c5a40280] [M] [info] msg: loading mid: 82fe3eae-6cae-40b0-b378-c79ec256c39e@marvin.tekkirk.org
[16:31:47] [0x00007f29c5a40280] [M] [info] msg: filename: /home/ligi/Maildir-notmuch/tekkirk/.Notmuch/cur/1693398624.M121474830P2143943Q2Rcdce051c.wand:2,S
[16:31:47] [0x00007f29c5a40280] [M] [info] db: closing db.
[16:31:47] [0x00007f29c5a40280] [M] [warning] pc: got extension connect
[2023-08-30 16:31:47.478650] [0x00007f783bfff640] [debug]   reader thread: started.
[2023-08-30 16:31:47.478665] [0x00007f783bfff640] [debug]   reader waiting..
[2023-08-30 16:31:47.553254] [0x00007f78aa3241c0] [debug]   page created.
[2023-08-30 16:31:47.597430] [0x00007f78aa3241c0] [debug]   request: /home/ligi/.config/astroid/wj94r5oh89rzjtr12zga4p8j5e1epmi2q..
[2023-08-30 16:31:47.597444] [0x00007f78aa3241c0] [debug]   request: allow.
[2023-08-30 16:31:47.602532] [0x00007f78aa3241c0] [debug]   request: about:srcdoc..
[2023-08-30 16:31:47.602546] [0x00007f78aa3241c0] [debug]   request: allow.
[2023-08-30 16:31:47.604428] [0x00007f783bfff640] [debug]   reader waiting..
[16:31:47] [0x00007f29c5a40280] [M] [info] chunk: contents: loaded 269 bytes in 0.055 ms.
[16:31:47] [0x00007f29c5a40280] [M] [info] chunk: file size: 269 (time used to calculate: 0.084 s.)
[16:31:47] [0x00007f29c5a40280] [M] [info] tv: ready emitted.

(astroid:2604334): gmime-CRITICAL **: 16:31:47.884: internet_address_list_length: assertion 'IS_INTERNET_ADDRESS_LIST (list)' failed

(astroid:2604334): gmime-CRITICAL **: 16:31:47.884: internet_address_list_length: assertion 'IS_INTERNET_ADDRESS_LIST (list)' failed
[16:31:47] [0x00007f29a0ff9640] [M] [error] address: no address in string.

(astroid:2604334): GLib-GObject-CRITICAL **: 16:31:47.884: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
[16:31:48] [0x00007f29a0ff9640] [M] [info] db: closing db.
[16:31:48] [0x00007f29c5a40280] [M] [info] db: open db read-only, waiting for lock..
[16:31:48] [0x00007f29c5a40280] [M] [info] db: closing db.
olynch commented 1 year ago

I have a similar problem.

kirschner commented 1 year ago

Not sure, but might that also be connected to https://github.com/astroidmail/astroid/issues/720 ?

l1gi commented 1 year ago

Maybe, but I would guess this issue relates to thread-view.scss, not part.scss.

Still don't know what to try.

rothn commented 1 year ago

Rebasing onto https://github.com/ibuclaw/astroid/tree/remove_iframes seems to fix the issue for me

Radvendii commented 1 year ago

Can confirm that this works for me too. Astroid is basically unusable without it, so I'll have to use it for now but it would be good to know what the implications of removing iframes are. The commit message mentions some possible security problems? EDIT: just found the PR where it's being discussed

hermann-p commented 8 months ago

Is there any progress made? I find it tricky to create a nix overlay that rebases on the branch mentioned above, and as @Radvendii mentioned, Astroid is basically unusable that way...

Radvendii commented 8 months ago

I made a branch with the changes in it. You can use this overlay for now

(final: prev: {
  astroid = prev.astroid.overrideAttrs {
    src = final.fetchFromGitHub {
      owner = "Radvendii";
      repo = "astroid;
      rev = "e756615cdeaa8e3e3bb3ecc6caf23a282f6e6872";
      sha256 = "";
    };
    # fixes have been committed upstream
    patches = [ ];
  };
})

Not sure what the sha256 is because in my config I pull it in as a flake input.

gauteh commented 8 months ago

Does https://github.com/astroidmail/astroid/pull/743 fix it?

jorsn commented 4 months ago

You can already use #747 in Nixpkgs using 

final: prev:
{
  astroid = prev.astroid.overrideAttrs (old: {
    version = "0.16.2024-05-28";
    src = fetchFromGitHub {
      owner = "astroidmail";
      repo = "astroid";
      rev = "c7b223bd91f6b8d19307aaba67fc4bff28d1368f";
      hash = "sha256-ex+3AUu4VJRnYf2fKs23J68/xKCcIxZxK/Rv9d86+IU=";
    };
    patches = [];
  });
}

EDIT: Updated rev and hash to head of PR.