Open jimcheetham opened 4 years ago
I looked a bit harder at all of /Users/jim/Library/Logs/Homebrew/webkitgtk/02.ninja
:-
FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource123.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DBUILDING_GTK__=1 -DBUILDING_JavaScriptCore -DBUILDING_WITH_CMAKE=1 -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFI
G_H=1 -DJSC_COMPILATION -DJSC_GLIB_API_ENABLED -DJavaScriptCore_EXPORTS -DSTATICALLY_LINKED_WITH_WTF -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -IDerivedSources/ForwardingHeaders -I. -
I../Source/JavaScriptCore -I../Source/JavaScriptCore/API -I../Source/JavaScriptCore/assembler -I../Source/JavaScriptCore/b3 -I../Source/JavaScriptCore/b3/air -I../Source/JavaScript
Core/bindings -I../Source/JavaScriptCore/builtins -I../Source/JavaScriptCore/bytecode -I../Source/JavaScriptCore/bytecompiler -I../Source/JavaScriptCore/dfg -I../Source/JavaScriptC
ore/disassembler -I../Source/JavaScriptCore/disassembler/ARM64 -I../Source/JavaScriptCore/disassembler/udis86 -I../Source/JavaScriptCore/domjit -I../Source/JavaScriptCore/ftl -I../
Source/JavaScriptCore/heap -I../Source/JavaScriptCore/debugger -I../Source/JavaScriptCore/inspector -I../Source/JavaScriptCore/inspector/agents -I../Source/JavaScriptCore/inspector
/augmentable -I../Source/JavaScriptCore/inspector/remote -I../Source/JavaScriptCore/interpreter -I../Source/JavaScriptCore/jit -I../Source/JavaScriptCore/llint -I../Source/JavaScri
ptCore/parser -I../Source/JavaScriptCore/profiler -I../Source/JavaScriptCore/runtime -I../Source/JavaScriptCore/tools -I../Source/JavaScriptCore/wasm -I../Source/JavaScriptCore/was
m/js -I../Source/JavaScriptCore/yarr -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCo
re/yarr -IDerivedSources/ForwardingHeaders/JavaScriptCore/glib -IDerivedSources/JavaScriptCore/javascriptcoregtk/jsc -I../Source/JavaScriptCore/API/glib -IDerivedSources/JavaScript
Core/javascriptcoregtk -I../Source/JavaScriptCore/inspector/remote/glib -I../Source/bmalloc -IDerivedSources -I../Source/ThirdParty -isystem /usr/local/include/glib-2.0 -isystem /u
sr/local/lib/glib-2.0/include -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith
-Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -Wno-unused-lambda-capture -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++14 -O2 -g -DNDEBUG -isysr
oot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -fPIC -ffp-contract=off -MD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCo
re/unified-sources/UnifiedSource123.cpp.o -MF Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource123.cpp.o.d -o So
urce/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource123.cpp.o -c DerivedSources/JavaScriptCore/unified-sources/Unifie
dSource123.cpp
In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource123.cpp:8:
../Source/JavaScriptCore/tools/JSDollarVM.cpp:175:37: error: reference to 'Handle' is ambiguous
bool isReachableFromOpaqueRoots(Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor) override
^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/MacTypes.h:249:41: note: candidate found by name lookup is 'Handle'
typedef Ptr * Handle;
^
../Source/JavaScriptCore/heap/Handle.h:109:29: note: candidate found by name lookup is 'JSC::Handle'
template <typename T> class Handle : public HandleBase, public HandleConverter<Handle<T>, T> {
^
1 error generated.
Looks like the MacOS "Handle" definition conflicts with the JavaScriptCore "Handle" definition. I see that's been fixed in the Webkit source:
bool isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor, const char** reason) final
from a later release:
Maybe someone can update this?
Trying to install the current astroid on macOS Catalina 10.15.5 19F96 x86_64
'ninja install' failed after one warning & one note, but no obvious errors.
I tried
brew install astroid --HEAD
but apparently my branch was already up to date :-) and I got the same result.