search

astrojuanlu / fenics-recipes

This repository contains conda recipes for the FEniCS libraries
The Unlicense
13 stars 15 forks source link

Pull request to fix vtk package #50

Open quang-ha opened 8 years ago

quang-ha commented 8 years ago

This add vtk build file and hence should fix the vtk incompatibility with conda.

Still requires OpenGL to be installed on the system though.

astrojuanlu commented 8 years ago

Thanks a lot for this pull request! I am a bit confused though: I see that you have been making changes related to OS X. Did the rest of the recipes work there? There is a number of issues concerning OS X so this surprises me.

On the other hand, the reason to comment out the VTK requirements was to be able to build the packages in a headless server - without X. Still, this improvements would be useful for those who want to build the package.

On a last note, how is the VTK recipe here different from the one provided in https://github.com/conda/conda-recipes/tree/master/vtk?

quang-ha commented 8 years ago

@Juanlu001 they are basically the same, small changes from g++44 into g++.

I don't have a Mac so not sure if it fixed. It solves my problem. Perhaps introduce a new channel for this conda package?

Quang

astrojuanlu commented 8 years ago

Oh, now I understand. In that case I will leave the pull request as it is. Unfortunately uploading this package to Anaconda, with a explicit dependency on OpenGL, will earn me a lot of bug reports because it will only work on the distribution I used to compile it - which totally defeats the purpose of having a conda package in the first place. I'm glad that it worked for you still.

quang-ha commented 8 years ago

I am looking at writing recipe for OpenGL with Conda. Hopefully can fix this.

astrojuanlu commented 8 years ago

Please ping me if you manage to do so! :four_leaf_clover: