search

astrolabsoftware / fink-science-portal

Fink Science Portal
https://fink-portal.org
Apache License 2.0
7 stars 4 forks source link

Increase z-index for the Aladin Lite div in the object page #605

Closed JulienPeloton closed 6 months ago

JulienPeloton commented 6 months ago

The new Aladin Lite v3 in full screen mode is not correctly displayed (the top is below the navbar) in an object page.

Screenshot from 2024-03-25 23-55-07

karpov-sv commented 6 months ago

I would say they changed something in the code as it definitely did not look that ugly just a couple of weeks ago. Really hope they will revert it back...

image
karpov-sv commented 6 months ago

I propose the following fix - basically, downgrading from (just released) v3.3 to the previous version, and fixing it to avoid such unexpected changes in the future:

diff --git a/app.py b/app.py
index bd27639..017637b 100644
--- a/app.py
+++ b/app.py
@@ -39,7 +39,7 @@ external_stylesheets = [
 ]
 external_scripts = [
     '//code.jquery.com/jquery-1.12.1.min.js',
-    '//aladin.u-strasbg.fr/AladinLite/api/v3/latest/aladin.js',
+    '//aladin.u-strasbg.fr/AladinLite/api/v3/3.2.0/aladin.js',
     '//cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js',
 ]
JulienPeloton commented 6 months ago

thanks for the proposal, I fully agree. The new changes are interesting, but indeed it is not yet enough mature (e.g. a lot of superposition of objects) to be integrated.