search

astrolabsoftware / fink-science

Define your science modules to add values to Fink alerts!
https://fink-broker.readthedocs.io/en/latest/broker/science_modules/
Apache License 2.0
11 stars 17 forks source link

[Bug] anomaly detection models have wrong name #461

Closed JulienPeloton closed 2 days ago

JulienPeloton commented 2 days ago

@Knispel2 The zip files in data/model/anomaly_detection have correct names (with _{model} in it), but once decompressed we always end up with the same names

forest_g_AAD.onnx
forest_r_AAD.onnx

while the code supposes the model name in the filename:

g_model_path_AAD = f"{tmp_path}/forest_g_AAD{model}.onnx"
r_model_path_AAD = f"{tmp_path}/forest_r_AAD{model}.onnx"

Todo: decompress files, rename each model, recompress folders, push.

JulienPeloton commented 2 days ago

The error was unfortunately not caught by the CI because I skipped anomaly tests on a (merged) branch (https://github.com/astrolabsoftware/fink-science/commit/4191e9403cf2189e0b22cc618b6afe224469a42c), and I forgot to restore it... My fault!

JulienPeloton commented 2 days ago

Fortunately, only the model "" is used in production.

Knispel2 commented 1 day ago

I'm sorry, I was too inattentive... Thanks a lot for fixing it!