search

astrolabsoftware / spark3D

Spark extension for processing large-scale 3D data sets: Astrophysics, High Energy Physics, Meteorology, …
https://astrolabsoftware.github.io/spark3D/
Apache License 2.0
30 stars 16 forks source link

Fix wrong angle definition in cartesian to spherical coordinate change! #102

Closed JulienPeloton closed 6 years ago

JulienPeloton commented 6 years ago

Bug fix in cartesianToSpherical. Following definition here and here, one should use atan2 and not acos or atan.

The astropy code is pretty useful as well.

codecov-io commented 6 years ago

Codecov Report

Merging #102 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          32       32           
  Lines        1240     1240           
  Branches      217      218    +1     
=======================================
  Hits         1195     1195           
  Misses         45       45
Flag Coverage Δ
#python 94.3% <ø> (ø) :arrow_up:
#scala 97.24% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
src/main/scala/com/spark3d/utils/Utils.scala 97.36% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14e5095...a1a9666. Read the comment docs.