test_scala fails because of python

astrolabsoftware / spark3D

Spark extension for processing large-scale 3D data sets: Astrophysics, High Energy Physics, Meteorology, …

https://astrolabsoftware.github.io/spark3D/

Apache License 2.0

30 stars 16 forks source link

test_scala fails because of python #118

Closed plaszczy closed 4 years ago

plaszczy commented 5 years ago

test_scala uses a python call to retrieve SCALA_BINARY_VERSION. However -this requires setting the PYTHONPATH -it requires having py4j installed

it woulds be better to avoid any python calls.

JulienPeloton commented 5 years ago

Hi @plaszczy,

Thanks, I agree for pure Scala user this seems baroque at first sight... This trick is mainly to avoid duplicating the information about versions. However you do not need the python call if you specify the scala version number as argument:

# e.g. using Scala 2.11.8
./test_scala 2.11.8

The python call is only there when the script is called without explicit scala version.

JulienPeloton commented 5 years ago

maybe you could use directly a scala call. version number is availbale in scala.util.Properties.versionNumberString

The easiest thing would be to hardcode the default version inside the test script though...

JulienPeloton commented 4 years ago

Fixed in #120