Fix trailing slash - Githubissues

astrolicious / i18n

Yet another i18n integration for Astro with server and client utilities, type safety and translations built-in.

https://astro-i18n.netlify.app/

MIT License

55 stars 3 forks source link

Closed nojaf closed 2 months ago

nojaf commented 2 months ago

Hi @florian-lefebvre, I believe I have found a fix for #24.

The problem was only ever happening on the root of a locale without a trailing slash. F.ex. http://localhost:4322/fr.

So I remove the trailing slash in the middleware.

netlify[bot] commented 2 months ago

Name	Link
Latest commit	f66565293d772933dd11d64aa58834c796ba3c85
Latest deploy log	https://app.netlify.com/sites/astro-i18n-demo/deploys/66d9a87eeb44190008597313
Deploy Preview	https://deploy-preview-34--astro-i18n-demo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Name	Link
Latest commit	f66565293d772933dd11d64aa58834c796ba3c85
Latest deploy log	https://app.netlify.com/sites/astro-i18n/deploys/66d9a87e8b72aa00087df9bb
Deploy Preview	https://deploy-preview-34--astro-i18n.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amosbastian commented 1 month ago

Funnily enough I think this caused #38 😆

florian-lefebvre commented 1 month ago

Yeah that's likely, if you find how to fix it I take it :laughing: