astronautlevel2 / Anemone3DS

A theme and boot splash manager for the Nintendo 3DS console
GNU General Public License v3.0
908 stars 44 forks source link

Completed C++ rewrite #200

Closed LiquidFenrir closed 5 years ago

LiquidFenrir commented 5 years ago

Hello, finally completed this thing I wanted to do. My last contribution. It shouldn't be able to crash, if nothing messes up.
Fixes the infamous scroll crash by abusing events, and adds badge support.
The only things missing are the install check/indicator, and a few touchscreen controls, that I thought wouldn't fit well.
Based on an old redesign by kenn, it's not too hard to bring back to the old style if it doesn't please the crowd.
HEAVILY NEEDS TESTING. If anything doesnt work before the merge, I'll try to fix it. Once it's merged, out of my hands. Enjoy and have a nice day.

catfatwm commented 5 years ago

Was this impliminted?

Helloman892 commented 5 years ago

Does it look like it was implemented?

Apologies for the sarcasm, but you can check these things yourself. This PR is still awaiting a full testing cycle, which I am not currently in a position to take part in - that is why it hasn't been merged yet.

Helloman892 commented 5 years ago

Currently crashes on either launch or exit on new3DS. Looking for a fix, but it might be a bug in citro2d. Fixed by commit 24e3291.

Helloman892 commented 5 years ago

Now crashes on trying to download the theme list from Theme Plaza. Backtrace as follows:

[Switching to Thread 217]
ndspiReadChnState ()
    at /home/fincs/pacman-packages/libctru/src/ctrulib-1.6.0/libctru/source/ndsp/ndsp-channel.c:446
446     /home/fincs/pacman-packages/libctru/src/ctrulib-1.6.0/libctru/source/ndsp/ndsp-channel.c: No such file or directory.
(gdb) bt
#0  ndspiReadChnState ()
    at /home/fincs/pacman-packages/libctru/src/ctrulib-1.6.0/libctru/source/ndsp/ndsp-channel.c:446
#1  0x00159928 in ndspSync ()
    at /home/fincs/pacman-packages/libctru/src/ctrulib-1.6.0/libctru/source/ndsp/ndsp.c:344
Backtrace stopped: Cannot access memory at address 0x8020fdc

(ndsp yes!)