search

astronautlevel2 / Anemone3DS

A theme and boot splash manager for the Nintendo 3DS console
GNU General Public License v3.0
908 stars 44 forks source link

No proper handling when the filename isn't specified but the target is a file (http_get) #220

Closed Helloman892 closed 3 years ago

Helloman892 commented 4 years ago

We don't correctly* handle the case where the filename parameter isn't actually filled. See here.

astronautlevel2 commented 4 years ago

I'm not entirely familiar w/ content disposition, in the case filename isn't provided, is there any other way to get the name of the file?

Helloman892 commented 4 years ago

Not sure, but it'd be documented there. I'll have a look in a bit.

Helloman892 commented 4 years ago

@astronautlevel2: The way to handle this would probably be to fire up the swkbd and ask for a name to save as if none is given in the header.

Helloman892 commented 4 years ago

Also, we currently handle it here; we should probably handle this differently than just assuming that the target isn't valid at all. I'll look into this more when we come around to the rewrite.

See here for how we could handle this in the future.

Helloman892 commented 3 years ago

240 makes an attempt at fixing this, but ultimately doesn't yet. I'll finish that up promptly.