astronautlevel2 / Anemone3DS

A theme and boot splash manager for the Nintendo 3DS console
GNU General Public License v3.0
887 stars 42 forks source link

Make BUF_TO_READ larger to fix audio in some cases #260

Closed LiquidFenrir closed 2 years ago

LiquidFenrir commented 2 years ago

If the preview .ogg has a samplerate > the BUF_TO_READ constant, there was an out of bounds write to the audio buffers which resulted in crackling. Thus, upped it to 48000 (0x80-aligned, and pretty much the highest rate anything consumer goes). a bit big, but safe.

Zemogiter commented 2 years ago

Added this PR to latest commit, used the .3dsx version since bannertool and makerom I can't figure out how to install, can confirm it fixes the issues.