search

astronomer / airflow-provider-great-expectations

Great Expectations Airflow operator
http://greatexpectations.io
Apache License 2.0
157 stars 53 forks source link

Test failure due to `apache-airflow-providers-snowflake` 4.3.1 #114

Open cdkini opened 1 year ago

cdkini commented 1 year ago

Hey there! I'm one of the core devs from the GX team and wanted to reach out to highlight a test failure we've been seeing in our CI - tests/operators/test_great_expectations.py::test_great_expectations_operator__make_connection_string_snowflake_pkey

As part of our CI, we clone this repository, install dependencies, and run the full suite. I've done some debugging and have come to the conclusion that this is a result of the new 4.3.1 release; testing on 4.3.0 passes all tests.

Here's where it fails:

# test_great_expectations_operator__make_connection_string_snowflake_pkey
>       assert operator.make_connection_configuration() == test_conn_conf

tests/operators/test_great_expectations.py:911:

Here's the specific part of the snowflake package that fails:

        elif private_key_file:
            private_key_file_path = Path(private_key_file)
            if not private_key_file_path.is_file() or private_key_file_path.stat().st_size == 0:
>               raise ValueError("The private_key_file path points to an empty or invalid file.")
E               ValueError: The private_key_file path points to an empty or invalid file.

/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/airflow/providers/snowflake/hooks/snowflake.py:253: ValueError