search

astronomer / airflow-provider-great-expectations

Great Expectations Airflow operator
http://greatexpectations.io
Apache License 2.0
159 stars 54 forks source link

Replace `setup.py` with `setup.cfg` #67

Closed kaxil closed 1 year ago

kaxil commented 1 year ago

New projects are advised to avoid setup.py configurations (beyond the minimal stub) when custom scripting during the build is not necessary as documented in https://setuptools.pypa.io/en/latest/userguide/quickstart.html

denimalpaca commented 1 year ago

The tests are failing because the following test expects that dir on PYTHONPATH!

Can we move it under tests @denimalpaca ?

https://github.com/astronomer/airflow-provider-great-expectations/blob/main/tests/operators/test_great_expectations.py#L526-L531

Sure, if it'll fix the testing it should be fine. I don't think it'll mess with anything -- @talagluck do you have an opinion here?

talagluck commented 1 year ago

I don't have an opinion here - if this is in line with other providers, then it feels reasonable to change.

kaxil commented 1 year ago

I don't have an opinion here - if this is in line with other providers, then it feels reasonable to change.

All those files in the /include folder are just for tests, right?

denimalpaca commented 1 year ago

they're used for the example DAG, too, so maybe they can be copied over to the tests/ dir and kept in include/ as well. Then the example DAG paths don't have to change.