search

astronomer / airflow-provider-great-expectations

Great Expectations Airflow operator
http://greatexpectations.io
Apache License 2.0
159 stars 54 forks source link

add support for Athena (aws_default) airflow connection #90

Closed diman82 closed 1 year ago

diman82 commented 1 year ago

There is even a TODO comment in operator code for adding support for Athena connection. Can you please add support for this?

denimalpaca commented 1 year ago

I'm happy to open a PR here and add it, but I don't have access to an Athena instance to run tests against (could only do local tests, which are only so helpful). I can open that PR today and if you want to do live tests against it, that would help me a lot in getting this added ASAP.

diman82 commented 1 year ago

Hey @denimalpaca. Sure, I can help with testing!

denimalpaca commented 1 year ago

@diman82 please see the PR linked!

lionsdwarf commented 1 year ago

There is even a TODO comment in operator code for adding support for Athena connection. Can you please add support for this?

Here's the permalink instead

denimalpaca commented 1 year ago

Hey @lionsdwarf , PR #91 is open with this addition. I don't have access to Athena and can't test, however, so I'm just waiting for @diman82 or someone else to test the fix before I do a merge and release. If you'd like to help, we can close this issue out this week!

lionsdwarf commented 1 year ago

We are interested in Trino support, which is also mentioned in the TODO comment.

I was curious if the recent upgrade to the core gx library to use database connection strings (instead of config parameters) would solve this problem, but it looks to me like the provider is already using the latest core version.

denimalpaca commented 1 year ago

Could you please open a separate issue for Trino support? I can look into opening another PR, but as I don't have access to Trino either, I'd need someone else to test it before I merge.

This and the Athena support is only for the default datasource being built; you can still use this operator with Trino now if you are supplying a checkpoint and have your datasources configured in the data context config.