astronomer / apache-airflow-providers-transfers

https://apache-airflow-provider-transfers.rtfd.io/
Apache License 2.0
11 stars 3 forks source link

Add append and replace load strategies with example DAG for Table #45

Closed sunank200 closed 1 year ago

sunank200 commented 1 year ago

Description

What is the current behavior?

Although the logic for the replace and append is implemented this is not working because if_exists is not propagated from TransferParams here: https://github.com/astronomer/apache-airflow-provider-transfers/blob/main/src/universal_transfer_operator/data_providers/database/base.py#L202

closes: #47

What is the new behavior?

Does this introduce a breaking change?

No

Checklist

sunank200 commented 1 year ago
Screenshot 2023-03-30 at 12 44 19 AM
utkarsharma2 commented 1 year ago

Can we add test cases to validate the behavior?

  1. Append to table
  2. Replace to table
sunank200 commented 1 year ago

Add tests

Added the tests: https://github.com/astronomer/apache-airflow-provider-transfers/pull/45/commits/9d9f5e8427ec66092341e4fb60f4205fb55ecebb