astronomer / ask-astro

An end-to-end LLM reference implementation providing a Q&A interface for Airflow and Astronomer
https://ask.astronomer.io/
Apache License 2.0
196 stars 47 forks source link

Change ingest params from upsert=True/False to use `existing` param. #110

Closed mpgreg closed 11 months ago

mpgreg commented 1 year ago

https://github.com/astronomer/ask-astro/blob/c45487c7f12a9424dbe885580c687e35e30b7de4/airflow/include/tasks/ingest.py#L38

When adding upsert logic to the weaviate provider an incorrect upsert parameter was created instead of using existing. Need to clean this up and only use existing='skip'|'replace'|'upsert'

Lee-W commented 11 months ago

It seems this no longer exists in the codebase. Close this one.