search

astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
359 stars 70 forks source link

astro deploy --save not saving deployment ID from menu. #1389

Open ddsmith2-eprod opened 1 year ago

ddsmith2-eprod commented 1 year ago

Describe the bug

When using astro deploy -s or --save and choosing a deployment from the menu the deploy is not saved in ./.astro/config.yaml and there is no warning. After testing we found that you have to copy/paste the deployment ID to use save, for example "astro deploy 13o5u15ndfgeirg -s".

What CLI Version did you experience this bug?

1.18.2

This CLI bug is related to which Astronomer Platform?

[ ] Astro [ x ] Software [ ] None/Unknown

What Operating System is the above CLI installed on?

Tested on Oracle Linux and Ubuntu.

🪜 Steps To Reproduce

create multiple deployments astro deploy pick a deployment number like 3 with -s "astro deploy --save" choose menu option e.g. 1 check ./astro/config.yaml and deployment ID is missing

nsAstro commented 1 year ago

Seems pretty small, but I think this is an important part of the user experience. Saving the deployment ID protects the user from accidentally deploying to the wrong deployment in the future by storing it to the project. Additionally, the time lost from having to manually select the deployment ID each time a user deploys can add up pretty quick especially in larger teams.