astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
355 stars 70 forks source link

Always `--pull` when building image #1407

Closed jedcunningham closed 2 weeks ago

jedcunningham commented 1 year ago

✍️ Is your feature request related to a problem? Please describe.

We'd like to start offering floating tags for Runtime (e.g. a astro-runtime:9) which will always point to the latest release in a given major. One challenge, however, is to make sure the latest image is used when building the image.

🧩 Describe the solution you'd like

Add --pull to the build command.

🤔 Describe alternatives you've considered

We could alternatively document customers need to do an explicit pull before an astro deploy etc, but that seems easy to forget and not very polished. One extra request to make sure the image is up to date is pretty cheap (locally, typically .1 second or so).

Is your feature request specific to a particular Astronomer Platform?

cmarteepants commented 1 year ago

@vishwas-astro @nicholasfilippi - I see this is in icebox. Is this something we can prioritize please? This is a blocker for us publishing runtime images with floating tags for major runtime versions.

If someone uses this batch of images, patch and minor runtime updates will happen automatically. If we don't change the pull method when building, docker will not check whether or not we have published a more recent version and will default to whatever is in the cache - meaning no automatic update.

sunkickr commented 1 year ago

does this fix the issue? https://github.com/astronomer/astro-cli/pull/1415

cmarteepants commented 1 year ago

I think so - @melugoyal @jedcunningham ?

jedcunningham commented 1 year ago

Yes it does.