astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
347 stars 70 forks source link

DEV- Workload identity string is set to empty while inspecting the deployment #1571

Open shri-astro opened 6 months ago

shri-astro commented 6 months ago

The following is the result of inspecting a standard AWS deployment

shrividyahegde@Hegde ~ % astro deployment inspect 
Select a Deployment
 #     DEPLOYMENT NAME                                                              RELEASE NAME                     DEPLOYMENT ID                 DAG DEPLOY ENABLED     
 1     autoqa_deployment_updated_to_A5_HA_False_KUBERNETES_SMALL19:38:30.383982     descriptive-gravitation-3685     clsufxsim000j01lw43svfs92     true                   
 2     test                                                                         nuclear-aphelion-9865            clt5m80ba09aw01lovx2a3j9t     true                   

> 2
deployment:
    configuration:
        name: test
        description: ""
        runtime_version: 10.4.0
        dag_deploy_enabled: true
        ci_cd_enforcement: false
        scheduler_size: SMALL
        is_high_availability: false
        is_development_mode: false
        executor: CELERY
        scheduler_count: 1
        workspace_name: Automation API dev workspace
        deployment_type: STANDARD
        cloud_provider: AWS
        region: us-east-1
        default_task_pod_cpu: "0.25"
        default_task_pod_memory: 0.5Gi
        resource_quota_cpu: "10"
        resource_quota_memory: 20Gi
        workload_identity: ""
    worker_queues:
        - name: default
          max_worker_count: 10
          min_worker_count: 0
          worker_concurrency: 5
          worker_type: A5
    metadata:
        deployment_id: clt5m80ba09aw01lovx2a3j9t
        workspace_id: cls8pqheo00i301pcq8x7bi1z
        cluster_id: N/A
        release_name: N/A
        airflow_version: 2.8.2
        current_tag: 10.4.0
        status: HEALTHY
        created_at: 2024-02-28T09:49:49.988Z
        updated_at: 2024-02-28T09:49:49.988Z
        deployment_url: cloud.astronomer-dev.io/cls8pqheo00i301pcq8x7bi1z/deployments/clt5m80ba09aw01lovx2a3j9t/overview
        webserver_url: cls8jv7rv005n01nwea4m87p5.astronomer-dev.run/dx2a3j9t?orgId=org_9zXCd6J5uyO30beS
    alert_emails:
        - shrividya.hegde@astronomer.io

Here the workload identity field is seen to be set to "" whereas the relevant details are seen for the field in Astro UI

What CLI Version did you experience this bug? 1.24.0

This CLI bug is related to which Astronomer Platform?

What Operating System is the above CLI installed on? Mac M1 Pro

📸 Screenshots

Screenshot 2024-02-28 at 3 42 55 PM
sunkickr commented 6 months ago

@jlaneve does it make sense to show workload identity in the UI on astro deployment inspect

kushalmalani commented 6 months ago

Also i get the following error with

astro deployment inspect --deployment-name kushal-test_DND --key configuration.workload_identity

Error: requested key configuration.workload_identity not found in deployment

shri-astro commented 6 months ago

#1584 just in case it's related