astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
341 stars 70 forks source link

Fix deployment create/update --deployment-file #1577

Closed feluelle closed 4 months ago

feluelle commented 4 months ago

Description

Describe the purpose of this pull request.

Currently, we don't pass the hibernation schedules from the deployment file into the deployment create operation. We also found out that the scaling spec was always set regardless of the development mode.

๐ŸŽŸ Issue(s)

fixes: #1576 fixes: #1578

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.46%. Comparing base (083ef7e) to head (e510459).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1577 +/- ## ========================================== + Coverage 86.45% 86.46% +0.01% ========================================== Files 113 113 Lines 15670 15682 +12 ========================================== + Hits 13547 13559 +12 Misses 1277 1277 Partials 846 846 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.