fix deployment variable create

sunkickr commented 4 months ago

Description

Fix the issue with deployment variable create where it cuts off the value at the first "=" character

🎟 Issue(s)

https://github.com/astronomer/astro-cli/issues/1595

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

[ ] Rebased from the main (or release if patching) branch (before testing)
[ ] Ran make test before taking out of draft
[ ] Ran make lint before taking out of draft
[ ] Added/updated applicable tests
[ ] Tested against Astro-API (if necessary).
[ ] Tested against Houston-API and Astronomer (if necessary).
[ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
[ ] Updated any related documentation

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.57%. Comparing base (6b79c3d) to head (6e9de85). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1605 +/- ## ======================================= Coverage 86.57% 86.57% ======================================= Files 114 114 Lines 15944 15944 ======================================= Hits 13804 13804 Misses 1284 1284 Partials 856 856 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kushalmalani commented 4 months ago

Can we add some unit tests and if we can test it manually too?

sunkickr commented 4 months ago

@kushalmalani Iv tested this manually

sunkickr commented 4 months ago

@kushalmalani I added a new test

astronomer / astro-cli