astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
341 stars 70 forks source link

update help message #1609

Closed sunkickr closed 4 months ago

sunkickr commented 4 months ago

Description

update help message to not say -1 but to say 0. In the past we haven't found a way to test cmd.Flags().Changed()

๐ŸŽŸ Issue(s)

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.57%. Comparing base (6b79c3d) to head (460dc2d). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1609 +/- ## ======================================= Coverage 86.57% 86.57% ======================================= Files 114 114 Lines 15944 15946 +2 ======================================= + Hits 13804 13806 +2 Misses 1284 1284 Partials 856 856 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sunkickr commented 4 months ago

tested manually

sunkickr commented 4 months ago

I added a temporary print statement to show that the PR is working. In the first screenshot the min worker count is not changed so the print statement shows the min count was changed to -1. In the second screenshot the min worker count is 0 so there is no print statement and the min worker count stays 0

Screenshot 2024-03-28 at 10 43 40 AM Screenshot 2024-03-28 at 10 44 12 AM