astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
350 stars 70 forks source link

Serialize extra object with `json.Marshal` #1610

Closed jeremybeard closed 6 months ago

jeremybeard commented 6 months ago

Description

This changes how the CLI serializes a connection's "extra" object (for use in the airflow connections add --conn-extra command) to use the standard library json.Marshal function, instead of hand-rolling JSON with string concatenation.

๐ŸŽŸ Issue(s)

Related #1608

๐Ÿงช Functional Testing

๐Ÿ“‹ Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.55%. Comparing base (f35749c) to head (d9f658f). Report is 1 commits behind head on main.

Files Patch % Lines
settings/settings.go 70.37% 5 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1610 +/- ## ========================================== - Coverage 86.59% 86.55% -0.04% ========================================== Files 114 114 Lines 16080 16084 +4 ========================================== - Hits 13924 13922 -2 - Misses 1293 1297 +4 - Partials 863 865 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.