astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
341 stars 70 forks source link

Token Management Add/Remove/List/Update #1611

Closed aliotta closed 3 months ago

aliotta commented 4 months ago

Description

Adds the ability to Add/Remove/List/Update the following

🎟 Issue(s)

Related #19973

🧪 Functional Testing

📸 Screenshots

Screenshot 2024-04-16 at 10 46 43 AM Screenshot 2024-04-16 at 10 50 03 AM Screenshot 2024-04-16 at 11 20 40 AM

📋 Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.25400% with 121 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (a9f4c7c) to head (124c82a). Report is 9 commits behind head on main.

Files Patch % Lines
cloud/workspace-token/workspace_token.go 82.90% 44 Missing and 29 partials :warning:
cloud/deployment/deployment_token.go 90.11% 13 Missing and 13 partials :warning:
cmd/cloud/deployment.go 91.30% 8 Missing and 8 partials :warning:
cloud/organization/organization_token.go 94.18% 3 Missing and 2 partials :warning:
cloud/team/team.go 97.22% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1611 +/- ## ========================================== + Coverage 86.59% 86.77% +0.18% ========================================== Files 114 114 Lines 16080 16661 +581 ========================================== + Hits 13924 14458 +534 - Misses 1293 1315 +22 - Partials 863 888 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kushalmalani commented 3 months ago

A bunch of the comments are applicable in other files too, so if you addressing them, please scan through all the files in this PR for similar changes.

Since this PR is adding a lot of new commands, it would be helpful if you can post screenshots of them working against dev for more confidence