astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
341 stars 70 forks source link

Remove Warning message on astro login #1621

Closed kushalmalani closed 3 months ago

kushalmalani commented 3 months ago

Description

Describe the purpose of this pull request.

Remove Warning message on astro login when a non astro domain is passed

Screenshot 2024-04-17 at 12 42 16

๐ŸŽŸ Issue(s)

Related #XXX

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.56%. Comparing base (d5f167e) to head (5eef4fd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1621 +/- ## ========================================== - Coverage 86.57% 86.56% -0.01% ========================================== Files 114 114 Lines 16090 16083 -7 ========================================== - Hits 13930 13923 -7 Misses 1296 1296 Partials 864 864 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sunkickr commented 3 months ago

Lets go with this for now