astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
334 stars 70 forks source link

Updating deploy commands to use v1beta deploy endpoints #1638

Closed kushalmalani closed 2 months ago

kushalmalani commented 2 months ago

Description

Describe the purpose of this pull request.

Updating deploy commands to use v1beta deploy endpoints

๐ŸŽŸ Issue(s)

Related astronomer/astro#19893, https://github.com/astronomer/astro-cli/issues/1181

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

Dag Only Deploy

Screenshot 2024-05-01 at 23 54 34

Image and Dag Deploy (astro deploy)

Screenshot 2024-05-01 at 23 54 46 Screenshot 2024-05-01 at 23 55 01

Cannot use --image and --dag flag together

Screenshot 2024-05-02 at 00 01 03

Image only deploy

Screenshot 2024-05-02 at 00 05 38 Screenshot 2024-05-02 at 00 05 59

๐Ÿ“‹ Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (3a21a22) to head (39b9a31).

Files Patch % Lines
cloud/deploy/deploy.go 90.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1638 +/- ## ========================================== + Coverage 86.74% 86.77% +0.03% ========================================== Files 114 114 Lines 16693 16690 -3 ========================================== + Hits 14480 14483 +3 + Misses 1323 1320 -3 + Partials 890 887 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.