search

astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
350 stars 70 forks source link

Block action when a yanked Runtime version is used #1642

Open jedcunningham opened 5 months ago

jedcunningham commented 5 months ago

✍️ Is your feature request related to a problem? Please describe.

Today, you can use any version of runtime ever released. However, some are known to be bad and broken.

🧩 Describe the solution you'd like

I'd love to see us block (with a flag to force past), or at least very noisily warn, when a yanked runtime image is used.

"Yanked" is a new concept for runtime, but there are new yanked and yankedReason flags that you can use to determine if a particular version is yanked and why.

Is your feature request specific to a particular Astronomer Platform?

No, this should apply everywhere I believe.

sunkickr commented 4 months ago

@paolaperaza should this only be blocked if an Org is not already using the version?

cmarteepants commented 3 months ago

@paolaperaza should this only be blocked if an Org is not already using the version?

No, it should be generally blocked, similar to creating deployments with yanked versions. Whenever we yank an image, we will be notifying people that are currently using the yanked version and strongly encouraging them to upgrade. We are only yanking versions in exceptional circumstances where people should really not be running that version.