astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
334 stars 70 forks source link

Fix a bug to create a deployment with same name in different workspace #1645

Closed kushalmalani closed 2 months ago

kushalmalani commented 2 months ago

Description

Describe the purpose of this pull request.

๐ŸŽŸ Issue(s)

Related #1644, #1360

Fix a bug to create a deployment with same name in different workspace

astrolocal deployment create --deployment-file ~/Desktop/temp.yaml
deployment:
    configuration:
        name: kushal-test

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.76%. Comparing base (8c81403) to head (07edd0b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1645 +/- ## ======================================= Coverage 86.76% 86.76% ======================================= Files 114 114 Lines 16693 16693 ======================================= Hits 14483 14483 Misses 1323 1323 Partials 887 887 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.