astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
334 stars 70 forks source link

fix error-code #1646

Closed sunkickr closed 2 months ago

sunkickr commented 2 months ago

Description

upgrade-test command doesn't return an exit code of 1 when the DAG parse test fails. This makes it so the failures doesn't stop their CI/CD pipeline

๐ŸŽŸ Issue(s)

manual testing

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (5e0cdac) to head (98890f9).

Files Patch % Lines
airflow/docker.go 66.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1646 +/- ## ======================================= Coverage 86.76% 86.77% ======================================= Files 114 114 Lines 16693 16697 +4 ======================================= + Hits 14483 14488 +5 Misses 1323 1323 + Partials 887 886 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.