astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
334 stars 70 forks source link

Don't log spurious error when extra is empty #1648

Closed jeremybeard closed 2 months ago

jeremybeard commented 2 months ago

Description

This fixes a spurious error log where if a connection is loaded into the Airflow DB, and the extra field on the connection is empty, it prints:

Error converting extra to map for my_conn_id, found type: <nil>

This does not block the connection from loading, but it is confusing, so this change removes it.

🧪 Functional Testing

📸 Screenshots

Before:

Screenshot 2024-05-10 at 10 19 00 AM

After:

Screenshot 2024-05-10 at 10 20 40 AM

📋 Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.76%. Comparing base (5e0cdac) to head (2398720).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1648 +/- ## ======================================= Coverage 86.76% 86.76% ======================================= Files 114 114 Lines 16693 16695 +2 ======================================= + Hits 14483 14485 +2 Misses 1323 1323 Partials 887 887 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.