astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
350 stars 70 forks source link

Reset the file pointer to the beginning of the file on each retry to send dags to dag server #1656

Closed rujhan-arora-astronomer closed 4 months ago

rujhan-arora-astronomer commented 4 months ago

Description

Reset the file pointer to the beginning of the file on each retry to send dags to dag server

๐ŸŽŸ Issue(s)

https://github.com/astronomer/issues/issues/6390

๐Ÿงช Functional Testing

Locally

๐Ÿ“‹ Checklist

rujhan-arora-astronomer commented 4 months ago

@rishkarajgi Do we need to backport this to the older cli versions too?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.72%. Comparing base (d858097) to head (69d2ad5).

Files Patch % Lines
pkg/fileutil/files.go 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1656 +/- ## ======================================= Coverage 86.72% 86.72% ======================================= Files 114 114 Lines 16707 16710 +3 ======================================= + Hits 14489 14492 +3 Misses 1329 1329 Partials 889 889 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rujhan-arora-astronomer commented 4 months ago

@kushalmalani Which is the next CLI version and when are we releasing it? Also, can you merge it too plz?

kushalmalani commented 4 months ago

@kushalmalani Which is the next CLI version and when are we releasing it? Also, can you merge it too plz?

Sure. There is no planned release. If this is a bug fix we can do a patch release tomorrow or early next week