astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
351 stars 70 forks source link

Fix inspecting deployment is_development_mode #1675

Closed feluelle closed 3 months ago

feluelle commented 3 months ago

Description

Update the deployment map to return the is_development_mode value instead of the pointer (address).

๐ŸŽŸ Issue(s)

โฏ astro deployment inspect clyoma4kq000l01nt2gohsr93 --clean-output --key configuration.is_development_mode
0x1400055b23e

๐Ÿงช Functional Testing

โฏ astro deployment inspect clyoma4kq000l01nt2gohsr93 --clean-output --key configuration.is_development_mode
false

๐Ÿ“‹ Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.31%. Comparing base (a8e81d7) to head (abc2a69).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1675 +/- ## ======================================= Coverage 86.31% 86.31% ======================================= Files 116 116 Lines 17052 17052 ======================================= Hits 14719 14719 Misses 1403 1403 Partials 930 930 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sunkickr commented 3 months ago

@kushalmalani I'm afraid we will need a release for this bug. Maybe we can create a release 1.27.2 with just this change since 1.28 is gonna be dbt on astro