astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
347 stars 70 forks source link

Block dbt deploys from within Astro project #1676

Closed jeremybeard closed 1 month ago

jeremybeard commented 1 month ago

Description

This change blocks the astro dbt deploy command from deploying a dbt project that is within an Astro project. This use case is not supported because it can create unexpected behavior when the full Astro project is then deployed with astro deploy.

๐Ÿงช Functional Testing

๐Ÿ“ธ Screenshots

Screenshot 2024-07-17 at 1 32 41โ€ฏPM

๐Ÿ“‹ Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.27%. Comparing base (a8e81d7) to head (a24d24d).

Files Patch % Lines
config/config_test_utils.go 60.00% 3 Missing and 3 partials :warning:
config/config.go 69.23% 2 Missing and 2 partials :warning:
cmd/cloud/dbt.go 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1676 +/- ## ========================================== - Coverage 86.31% 86.27% -0.05% ========================================== Files 116 117 +1 Lines 17052 17085 +33 ========================================== + Hits 14719 14740 +21 - Misses 1403 1409 +6 - Partials 930 936 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.