Run approval & new tag jobs only after lint & test are passing - Githubissues

astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer

https://www.astronomer.io

Other

361 stars 71 forks source link

Run approval & new tag jobs only after lint & test are passing #1700

Closed neel-astro closed 3 months ago

neel-astro commented 3 months ago

Description

Fix the order of jobs in CI when creating a new release. One can approve and build the release even if linting or unit tests are failing. This PR fixes that to block the release workflow if lint/test jobs are failing

Existing Workflow:

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

[x] Rebased from the main (or release if patching) branch (before testing)
[ ] Ran make test before taking out of draft
[ ] Ran make lint before taking out of draft
[ ] Added/updated applicable tests
[ ] Tested against Astro-API (if necessary).
[ ] Tested against Houston-API and Astronomer (if necessary).
[ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
[ ] Updated any related documentation