astronomer / astro-cli

CLI that makes it easy to create, test and deploy Airflow DAGs to Astronomer
https://www.astronomer.io
Other
361 stars 71 forks source link

Consolidate Create/Update/Logs deployment methods arguments to a struct #1709

Open neel-astro opened 2 months ago

neel-astro commented 2 months ago

As of now the create/update/logs deployment methods take in a load of individual arguments which are deployment properties, these arguments should be consolidated into a struct which would simplify calling the method, and help us avoid any potential issues concerning unordered arguments.

Code Reference: Create function: https://github.com/astronomer/astro-cli/blob/main/cloud/deployment/deployment.go#L215 Update function: https://github.com/astronomer/astro-cli/blob/main/cloud/deployment/deployment.go#L741 Logs function: https://github.com/astronomer/astro-cli/blob/main/cloud/deployment/deployment.go#L138