Functionally, this really doesn't change much of anything. It is really just refactoring the startDocker() command to a new place. We've defined a new ContainerRuntime interface that will grow a bit in the next PR to cover container runtime lifecycle management functions. This places the original, directly in-line code into this new lifecycle management structure. We then call these functions from cobra pre-run hooks on our astro dev commands.
My original PR grew too large, so this is part 1 to get some of the basic structure in place for expansion, while not changing any behavior quite yet.
Description
Functionally, this really doesn't change much of anything. It is really just refactoring the
startDocker()command to a new place. We've defined a newContainerRuntimeinterface that will grow a bit in the next PR to cover container runtime lifecycle management functions. This places the original, directly in-line code into this new lifecycle management structure. We then call these functions from cobra pre-run hooks on ourastro devcommands.My original PR grew too large, so this is part 1 to get some of the basic structure in place for expansion, while not changing any behavior quite yet.
🎟 Issue(s)
Related to https://github.com/astronomer/astro/issues/24344
🧪 Functional Testing
astro devsubcommands have been tested manually and confirmed to be working as expected. (we should automate this as one of our next steps)📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft