astronomer / astro-provider-databricks

Orchestrate your Databricks notebooks in Airflow and execute them as Databricks Workflows
Apache License 2.0
20 stars 10 forks source link

Fix CI PyPI package release #39

Closed tatiana closed 1 year ago

tatiana commented 1 year ago

Change GitHub Actions workflow to release using Hatch instead of Twine so the packages created are valid.

Although the template repo astro-providers-template used hatch for package management, the astro-provider-databricks CI was configured to use Twine to release to PyPI. This PR aims to make package management tools consistent usage consistent.

We also had to yank a release created using the previous Github Actions workflow. This particular version was built/released using Github actions. A possible explanation for the issue is that we're using dynamic versioning and other things done differently in Twine.

How the CI workflow looks like when triggered from a Pull Request (publishing to PyPI is skipped):

Screenshot 2023-05-11 at 12 33 32

This is an example of a package successfully published to PyPI using Github actions: https://github.com/astronomer/astro-provider-databricks/actions/runs/4947422468 https://pypi.org/project/astro-provider-databricks/0.1.3a2/

Screenshot 2023-05-11 at 12 50 23
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2a19f29) 78.47% compared to head (dcd8a2d) 78.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ======================================= Coverage 78.47% 78.47% ======================================= Files 5 5 Lines 460 460 Branches 57 57 ======================================= Hits 361 361 Misses 78 78 Partials 21 21 ``` | [Impacted Files](https://app.codecov.io/gh/astronomer/astro-provider-databricks/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | Coverage Δ | | |---|---|---| | [src/astro\_databricks/\_\_init\_\_.py](https://app.codecov.io/gh/astronomer/astro-provider-databricks/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer#diff-c3JjL2FzdHJvX2RhdGFicmlja3MvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.