astronomer / astro-provider-databricks

Orchestrate your Databricks notebooks in Airflow and execute them as Databricks Workflows
Apache License 2.0
20 stars 10 forks source link

Add operator that supports all task types #55

Closed crong-k closed 11 months ago

crong-k commented 12 months ago

This PR adds a new operator to support all task types in Databricks.

jlaneve commented 12 months ago

Hey @crong-k, this looks great! Going to spend some time reviewing and testing it next week, but this is going to be awesome to get in.

crong-k commented 11 months ago

Hello @jlaneve , the CI is encountering a 'ModuleNotFoundError: No module named 'airflow'' error. Is there something I need to fix? If so, please let me know.

singhsatnam commented 11 months ago

Hi @crong-k, I was testing out this PR and to do that, I installed the astro-provider-databricks from this repo while building a docker image for Airflow.

I know that astro-provider-databricks was installed successfully as I was able to import packages like astro_databricks.operators.notebook import DatabricksNotebookOperator but I get a module not found exception when I import from astro_databricks import DatabricksTaskOperator or from astro_databricks.operators.common import DatabricksTaskOperator.

If you follow the same method to test this PR, what do you think I am doing wrong so that I am not able to import DatabricksTaskOperator? Thanks.

crong-k commented 11 months ago

Hello @singhsatnam , Please check the version with the following code:

import astro_databricks
print(astro_databricks.__version__)

Does it print out as 0.1.5?

jlaneve commented 11 months ago

@crong-k do you care if I push directly to your branch? going to make a few minor modifications as I'm reviewing!