search

astronomer / astro-provider-ray

This provider contains operators, decorators and triggers to send a ray job from an airflow task
https://astronomer.github.io/astro-provider-ray/
Apache License 2.0
12 stars 2 forks source link

Namespace bug fix #59

Closed venkatajagannath closed 2 months ago

venkatajagannath commented 2 months ago

While setting up a Ray cluster on K8, we need to provide namespace option.

The expected behavior is to pick the namespace provided in the connection (using self.get_namespace()) or use default

The code though has a bug. If the namespace is not provided in the connection, it does not use the default.

This is because the variable created in the init method is not used in the setup_ray_cluster & delete_ray_cluster methods. Instead a direct call is made to self.get_namespace()

This PR fixes that bug

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.16%. Comparing base (fd9807b) to head (bd4539a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 95.42% 98.16% +2.74% ========================================== Files 5 5 Lines 546 546 ========================================== + Hits 521 536 +15 + Misses 25 10 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.