astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
354 stars 45 forks source link

Tracking ticket for smart_open() - wasb support #1562

Open utkarsharma2 opened 1 year ago

utkarsharma2 commented 1 year ago

Please describe the feature you'd like to see In our code base, we should remove the following lines of code: https://github.com/astronomer/astro-sdk/blob/ba25f0c8bb7ab0a3e7d2873228bad9b36e7305e1/python-sdk/src/astro/files/locations/azure/wasb.py#L47-L61

once the ticket is resolved on smart open end - https://github.com/RaRe-Technologies/smart_open/issues/755

Describe the solution you'd like We should change it back to location.path

Are there any alternatives to this feature? Is there another way we could solve this problem or enable this use-case?

Acceptance Criteria

phanikumv commented 1 year ago

Waiting on RaRe-Technologies/smart_open#755 to be implemented

sunank200 commented 1 year ago

Added comment on the thread