astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
343 stars 42 forks source link

Comment out query_modifier param #1996

Closed pankajastro closed 1 year ago

pankajastro commented 1 year ago

PR https://github.com/astronomer/astro-sdk/pull/1962 was suppose to fix the query modifier but look like it didn't so disabling it

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04% :tada:

Comparison is base (c593075) 89.67% compared to head (aee0cff) 89.72%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1996 +/- ## ========================================== + Coverage 89.67% 89.72% +0.04% ========================================== Files 72 72 Lines 4262 4262 Branches 530 530 ========================================== + Hits 3822 3824 +2 + Misses 343 342 -1 + Partials 97 96 -1 ``` | Flag | Coverage Δ | | |---|---|---| | PythonSDK | `89.72% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/astronomer/astro-sdk/pull/1996/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pankajastro commented 1 year ago

ran dag locally worked fine. probably an issue with the way we install sdk in docker. closing it.