astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
342 stars 42 forks source link

Add github actions job for the creating/terminating databricks cluster #2043

Open Lee-W opened 1 year ago

Lee-W commented 1 year ago

Description

What is the current behavior?

run databricks testing on an existing cluster

What is the new behavior?

In this PR, I also unify the yaml style in .github. The main changes live in the first and the third commit

Does this introduce a breaking change?

no

Checklist

Lee-W commented 1 year ago

@phanikumv @tatiana We're now testing bringing up the databricks cluster and then terminating it after the tests. Could you please help us set up DATABRICKS_HOST in secret? Thanks!

tatiana commented 1 year ago

I just added the secret, @Lee-W !

Lee-W commented 1 year ago

Thanks @tatiana ! After a few tests, I found out we might need an extra secret here. Already DM you the secret. Could you please help us set it up? Thanks

tatiana commented 12 months ago

Hi @Lee-W , I just added it - thank you very much for working on this!

Lee-W commented 11 months ago

@Lee-W this ticket is hard work 😬 Please ping us when the tests are passing so we can merge it!

The next thing I'll try is make the secrets small strings instead of the whole json.

It seems structured data as json is not recommended by github https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#naming-your-secrets