astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
342 stars 42 forks source link

test(snowflake): add missing ORDER in column default #2044

Closed Lee-W closed 6 months ago

Lee-W commented 1 year ago

Description

What is the current behavior?

python-sdk/tests_integration/databases/test_snowflake.py::test_snowflake_create_table_with_columns fails

During testing on https://github.com/astronomer/astro-sdk/pull/2043, I found out there's this snowflake failure in integration test

What is the new behavior?

Does this introduce a breaking change?

no

Checklist

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a7b8819) 90.40% compared to head (83d83ba) 90.35%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2044 +/- ## ========================================== - Coverage 90.40% 90.35% -0.05% ========================================== Files 75 75 Lines 4324 4323 -1 Branches 537 537 ========================================== - Hits 3909 3906 -3 - Misses 321 330 +9 + Partials 94 87 -7 ``` | [Flag](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2044/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | Coverage Δ | | |---|---|---| | [PythonSDK](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2044/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | `90.35% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | Coverage Δ | | |---|---|---| | [python-sdk/src/astro/sql/operators/cleanup.py](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer#diff-cHl0aG9uLXNkay9zcmMvYXN0cm8vc3FsL29wZXJhdG9ycy9jbGVhbnVwLnB5) | `89.16% <100.00%> (-0.92%)` | :arrow_down: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2044/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Lee-W commented 11 months ago

@Lee-W, thanks for working on this!

Do you have any idea why "Build and test astro Python SDK / Build-Docs" is breaking? The change is not related to this change, so I'm approving it. It would be great for us to address that in a separate PR

Not quite sure 🤔 Let me rerun it and see how it works

Lee-W commented 11 months ago

seems to fail. might need to handle that in another pr

tatiana commented 6 months ago

@Lee-W it seems there is a conflict ATM - when you have a chance, please, take a look, so we can merge this

Lee-W commented 6 months ago

@Lee-W it seems there is a conflict ATM - when you have a chance, please, take a look, so we can merge this

I just rebased from main and found out it's no longer needed