astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
329 stars 40 forks source link

Remove databricks-sql-connector from pyproject.toml #2131

Closed pankajastro closed 3 months ago

pankajastro commented 3 months ago

We included the databricks-sql-connector dependency due to the reasons stated in the GitHub issue https://github.com/databricks/databricks-sql-python/issues/190. Now that this issue has been fixed, we should remove this dependency.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.02%. Comparing base (9a5dd6b) to head (42b81e8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2131 +/- ## ========================================== + Coverage 89.03% 90.02% +0.99% ========================================== Files 75 75 Lines 4322 4322 Branches 539 539 ========================================== + Hits 3848 3891 +43 + Misses 369 335 -34 + Partials 105 96 -9 ``` | [Flag](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2131/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | Coverage Δ | | |---|---|---| | [PythonSDK](https://app.codecov.io/gh/astronomer/astro-sdk/pull/2131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer) | `90.02% <ø> (+0.99%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=astronomer#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pankajastro commented 3 months ago

Thanks, @pankajastro ! If you have a chance, please, could you improve the PR description, explaining why and referencing databricks/databricks-sql-python#191?

updated the description. PTAL