search

astronomer / astro-sdk

Astro SDK allows rapid and clean development of {Extract, Load, Transform} workflows using Python and SQL, powered by Apache Airflow.
https://astro-sdk-python.rtfd.io/
Apache License 2.0
329 stars 40 forks source link

Remove condition import for SQLAlcRow #2146

Closed pankajastro closed 1 month ago

pankajastro commented 2 months ago

since airflow is pin to >2.7.0 remove conditional import https://github.com/astronomer/astro-sdk/blob/main/python-sdk/pyproject.toml#L20

Lee-W commented 1 month ago

Looks like the CI is failing. Just rerun it. Let's see how it works

Lee-W commented 1 month ago

Looks like the CI is failing. Just rerun it. Let's see how it works

It still fails. I think we might need to check it 🤔

pankajastro commented 1 month ago

It still fails. I think we might need to check it 🤔

Yes, it is broken since 2.9 I'm fixing in https://github.com/astronomer/astro-sdk/pull/2149

pankajastro commented 1 month ago

GTM. Some tests seems to be failing. Should we fix them in this PR or a subsequent PR is better? Leaving the call to you to decide @pankajastro

yeah, the failure is unrelated to this change, I'll merge this one to fix the import error in example DAG and will fix CI in https://github.com/astronomer/astro-sdk/pull/2149